28. Mär 2024, 15:37 Hallo Gast.
Willkommen Gast. Bitte einloggen oder registrieren. Haben Sie Ihre Aktivierungs E-Mail übersehen?

Einloggen mit Benutzername, Passwort und Sitzungslänge. Hierbei werden gemäß Datenschutzerklärung Benutzername und Passwort verschlüsselt für die gewählte Dauer in einem Cookie abgelegt.


Select Boards:
 
Language:
 


Autor Thema: No-time limit Submod: Issues and Bugs  (Gelesen 14089 mal)

Miaulë

  • Bilbos Festgast
  • *
  • Beiträge: 16
No-time limit Submod: Issues and Bugs
« am: 13. Sep 2021, 03:15 »
Hi all

I've almost finished this submod.
All summonable heroes and horde units are now free of their expiration time except the Oathbreakers hordes.
What I know is that they are under the names of :
   angmaroathbreakers; rohanoathbreakers ; rohanoathbreakerscavalry .
 
I checked all units file and I haven't been able to find them
 except a unit file named dunhargoathbreaker that hasn't the ModuleTag_Lifetime codeline.

Can someone help me?

The_Necromancer0

  • Edain Team
  • Beschützer des verbotenen Weihers
  • *****
  • Beiträge: 1.528
  • There is evil there that does not sleep
Re: No-time limit Submod: Issues and Bugs
« Antwort #1 am: 13. Sep 2021, 08:15 »
Hey, and welcome to the forums. Glad to see you're making good progress with the submod. Don't forget to send a PM to a member of the dev team before to get approval.

According to the wiki, the object for the Oathbreakers is called "RohanOathbreakerhordeSma ll" (see here: https://edain.fandom.com/wiki/Oathbreakers)

You should check if that horde has a lifetime update and see what units it is composed of.
Come chat Edain on Discord: https://discord.gg/CMhkeb8
Questions on the Mod? Visit the Official Wiki: http://edain.wikia.com/

Miaulë

  • Bilbos Festgast
  • *
  • Beiträge: 16
Re: No-time limit Submod: Issues and Bugs
« Antwort #2 am: 13. Sep 2021, 22:40 »
Thank you.
I did my search backwards and I had found the codeline in neutralobjects.
(this summon is linked to the vanilla file of summons)

Miaulë

  • Bilbos Festgast
  • *
  • Beiträge: 16
Re: No-time limit Submod: Issues and Bugs
« Antwort #3 am: 14. Sep 2021, 01:04 »
Well!
For all horde units and heroes the time limit has been removed.
Before deleting the timer on their portraits as well, I want solve first some duplications of special non hero character (Ghan-Buri-Ghan) and
heroic hordes (Grimbold,Elfhelm).
Furthermore, I would like to make selectable and controllable the individual summoned units of some heroes ( Beregond's white company, Denethor's summoned guards, Malbeth's guards, Haldir borderguards, Thranduil guards, Halbarad rangers).
What code-line should I change for that?

(about the duplication bug, the code-line "MaxSimultaneousOfType = 1" doesn't work for them. Does anyone have any hypotheses?)





The_Necromancer0

  • Edain Team
  • Beschützer des verbotenen Weihers
  • *****
  • Beiträge: 1.528
  • There is evil there that does not sleep
Re: No-time limit Submod: Issues and Bugs
« Antwort #4 am: 14. Sep 2021, 10:19 »
I'm not sure why MaxSimultaneousOfType isn't working for these, quite interesting. For the non-controllable stuff there are different things you need to do.

For some it's just a matter of adding SELECTABLE to their KindOf, for others, like Ghan-Buri-Ghan you have to rework how the spell works a little. Instead of spawning "slaved" units like it current does, it should just spawn units like a normal summon. I think it should be pretty similar to the way that Tauriel works, have a look at that perhaps.

I'll keep looking into why MaxSimultaneousOfType doesn't work.
Come chat Edain on Discord: https://discord.gg/CMhkeb8
Questions on the Mod? Visit the Official Wiki: http://edain.wikia.com/

Miaulë

  • Bilbos Festgast
  • *
  • Beiträge: 16
Re: No-time limit Submod: Issues and Bugs
« Antwort #5 am: 16. Sep 2021, 00:35 »
A good news and a sad news

The good news is I managed to make selectable Haldir borderguards, Thranduil Palace guards, Beregond white company and Halbarad rangers)

The sad news is I have not been able to make selectable the guards spawned like ranged attack of Denethor and Malbeth. Then, Beregond white company die after some time despite I removed all the time codelines.
I have no ideas why this happens.

About the duplications of Ghan-buri-ghan and heroic hordes (Grimbold,Elfhelm) I have not found a solution at the moment.
« Letzte Änderung: 16. Sep 2021, 22:22 von Miaulë »

Miaulë

  • Bilbos Festgast
  • *
  • Beiträge: 16
Re: No-time limit Submod: Issues and Bugs
« Antwort #6 am: 17. Sep 2021, 01:24 »
denethor and malbeth creeps are now selectable.

I have not been able to prevent death of Beregond company after an amount of time (approximately 27 seconds)

The_Necromancer0

  • Edain Team
  • Beschützer des verbotenen Weihers
  • *****
  • Beiträge: 1.528
  • There is evil there that does not sleep
Re: No-time limit Submod: Issues and Bugs
« Antwort #7 am: 17. Sep 2021, 09:02 »
Beregond's company is actually 6 individual units each with their own timer, did you remove the timers from:

GondorWächterderVesteCre ep1
GondorWächterderVesteCre ep2
GondorWächterderVesteCre ep3
GondorWächterderVesteCre ep4
GondorWächterderVesteCre ep5
GondorWächterderVesteCre ep6

In addition since it looks like they're attached to the BeregondKompanieObject object you might have to remove the timer from that to.
« Letzte Änderung: 17. Sep 2021, 09:08 von The_Necromancer0 »
Come chat Edain on Discord: https://discord.gg/CMhkeb8
Questions on the Mod? Visit the Official Wiki: http://edain.wikia.com/

Miaulë

  • Bilbos Festgast
  • *
  • Beiträge: 16
Re: No-time limit Submod: Issues and Bugs
« Antwort #8 am: 17. Sep 2021, 15:41 »
THANK YOU!
Thank you very much! <3
I never imagined there was a timer in "projectile" file.

Now I can proceed to remove the timers on portraits.

The only unresolved things are the summon duplications of Ghan-buri-ghan, Grimbold and Elfhelm

Miaulë

  • Bilbos Festgast
  • *
  • Beiträge: 16
Re: No-time limit Submod: Issues and Bugs
« Antwort #9 am: 17. Sep 2021, 17:09 »
Before submitting the publication request I would like to list the timers I have not changed:

Boromir ring corruption timer;

Mordor bats;

turncoats of arnor;

Huorns;

Mordor white wights;

Ered luin secondary heroes (bombur for example);

What do you think about?

The_Necromancer0

  • Edain Team
  • Beschützer des verbotenen Weihers
  • *****
  • Beiträge: 1.528
  • There is evil there that does not sleep
Re: No-time limit Submod: Issues and Bugs
« Antwort #10 am: 17. Sep 2021, 18:20 »
I'll have a look at the duplication issue this weekend, I find it weird that these battalions seem to escape the rule.

I think removing the timers on the Huorns and Ered Luin's secondary heroes should probably be fine. Unless there is a specific reason you didn't want to?

Also, have you considered leaving the time on the Oathbreakers and on the King of the Dead? I think that a permanent Army of the Dead sounds fun at first but since it's basically an automatic win button it might lose its savour quite quickly.

EDIT:
So I stumbled on something interesting while playing around in the map.ini, I made a child object from Grimbold's horde, removed the timer, added MaxSimultaneousOfType and replaced the horde in the OCL with the child object. When I tested it in the game that seemed to do the trick to prevent multiple instances from spawning. So might be worth playing around with child objects.

ChildObject GetreueReiterHordeGrimbold_SummonedMax GetreueReiterHordeGrimbold_Summoned
    RemoveModule ModuleTag_LifetimeUpdate
    MaxSimultaneousOfType = 1
End
« Letzte Änderung: 17. Sep 2021, 21:32 von The_Necromancer0 »
Come chat Edain on Discord: https://discord.gg/CMhkeb8
Questions on the Mod? Visit the Official Wiki: http://edain.wikia.com/

Miaulë

  • Bilbos Festgast
  • *
  • Beiträge: 16
Re: No-time limit Submod: Issues and Bugs
« Antwort #11 am: 17. Sep 2021, 22:53 »
Thanks. I immediately go to try this.

About oath breakers, yes they seem indestructible but 1 attack of sauron in armor destroys them; or a combination of tower fire arrows with garrison.

about huorns, they are immobile and I thinked it could create an excessive ground occupation.
For ered luin heroes I thinked there would be a no complete company because bombur remains "to cook" but probably I will remove their timers anyway

Miaulë

  • Bilbos Festgast
  • *
  • Beiträge: 16
Re: No-time limit Submod: Issues and Bugs
« Antwort #12 am: 18. Sep 2021, 11:40 »
Now the duplication of Elfelm and Grimbold hordes are now solved. I added the codeline under their childobject in the rohanhorde file.
Without your help It would have taken a lot longer.
Thanks!

The secondary ered luin heroes are summoned like "slave" so there is the same  problem of ghan-buri-ghan. Also they have some powers blocked. What should I do to make them available?

The_Necromancer0

  • Edain Team
  • Beschützer des verbotenen Weihers
  • *****
  • Beiträge: 1.528
  • There is evil there that does not sleep
Re: No-time limit Submod: Issues and Bugs
« Antwort #13 am: 19. Sep 2021, 18:46 »
With ghan-buri-ghan the way I did is that I replaced the OCL it spawns in the GoodSpellbook (it's module ModuleTag_SummonDruedain Allies). For fixing the duplicates the only way I figured out how to fix was a child object again.

To make the powers available you'll have to remove their requirement. There is usually a "starter" module that you have to remove and then in the specialpower module you have to switch StartsActive to Yes.

Here's my map.ini code for ghan-buri-ghan
Come chat Edain on Discord: https://discord.gg/CMhkeb8
Questions on the Mod? Visit the Official Wiki: http://edain.wikia.com/

Miaulë

  • Bilbos Festgast
  • *
  • Beiträge: 16
Re: No-time limit Submod: Issues and Bugs
« Antwort #14 am: 22. Sep 2021, 13:18 »
I solved the problem with your advice.
It was the  OCL= OCL_SpawnDruedainAlliese gg in the  objectcreationlist.inc

I have replaced it with summondruedainalliesMax like you did and I modified the Ghanburighan.ini, systemgood.inc, objectcreationlist.inc. Now he is unique on camp after other summons.

Now I try this for ered luin secondary heroes.